Code review comment for lp:kmsistemas-openerp-addons

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Jordi, thank you very much for pointing out the problem and its solution.

For the next time, please make the MP with an specific branch for solving the bug, because in this way, you get all the bugs that you have declared as related, as you can see here with "Bug #1256619: [6.1] report_stock_inventory wrongly declared column & SQL", that was previously reported and solved, but with the same branch.

BTW, I think it's safer to put 'if values.get('body_text')' and 'if values.get('body_html')' to avoid errors when a value is not present in the dictionary.

Regards.

review: Needs Fixing (code review)

« Back to merge proposal