Merge lp:~jorge/pyjuju/default-to-packages into lp:~charm-contributors/pyjuju/docs

Proposed by Jorge Castro
Status: Needs review
Proposed branch: lp:~jorge/pyjuju/default-to-packages
Merge into: lp:~charm-contributors/pyjuju/docs
Diff against target: 55 lines (+11/-11)
2 files modified
source/policy.rst (+11/-7)
source/provider-configuration-openstack.rst (+0/-4)
To merge this branch: bzr merge lp:~jorge/pyjuju/default-to-packages
Reviewer Review Type Date Requested Status
Clint Byrum (community) Needs Fixing
Juan L. Negron (community) Approve
Review via email: mp+126784@code.launchpad.net

Description of the change

Please don't merge yet while discussion happens on the juju list.

To post a comment you must log in.
Revision history for this message
Juan L. Negron (negronjl) wrote :

Looks good to me.

-Juan

review: Approve
Revision history for this message
Juan L. Negron (negronjl) wrote :

We should get more people's comments/reviews here before merging.

-Juan

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

I would change:

If the service is seeded

to

If the principal software needed to provide the service is available in a seeded package

Also it would be useful if you did the other 3 changes in a separate branch which this merge proposal can depend on. Its somewhat distracting seeing all of the changes at once here.

review: Needs Fixing
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

<poke> Whats the status on this?

Unmerged revisions

74. By Jorge Castro

* Revised policy to "must" default to packages if the service is in main.

73. By Jorge Castro

Fix up some footnotes

72. By Jorge Castro

* Be explicit about defaulting charms to packaged versions if in main?

71. By Jorge Castro

Remove mention of default-instance-type, this should be managed via constraints.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'source/policy.rst'
--- source/policy.rst 2012-08-15 18:22:32 +0000
+++ source/policy.rst 2012-09-27 19:53:22 +0000
@@ -1,5 +1,5 @@
1:Version: 0.1.11:Version: 0.1.2
2:Authors: Clint Byrum <clint@ubuntu.com>2:Authors: Clint Byrum <clint@ubuntu.com>, Jorge Castro <jorge@ubuntu.com>
3:Date: August 15, 20123:Date: August 15, 2012
44
5==================5==================
@@ -34,15 +34,16 @@
34 team or individual who are responsive to contact regarding the charm.34 team or individual who are responsive to contact regarding the charm.
35* must include a license. Call the file 'copyright' and make sure all35* must include a license. Call the file 'copyright' and make sure all
36 files' licenses are specified clearly. license_36 files' licenses are specified clearly. license_
37* must be under a Free license. license2_ 37* must be under a Free license2_
38* must have hooks that are idempotent idempotent_38* must have hooks that are idempotent_
39* must not run any network services using default passwords.39* must not run any network services using default passwords.
40* should default to use software that is included in the Ubuntu archive,40* If the service is seeded_ in the Ubuntu archive, it must default to that package,
41 however we encourage that charm authors have a config options for41 however we encourage that charm authors have a config options for
42 allowing users to deploy from newer upstream releases, or even right42 allowing users to deploy from newer upstream releases, PPAs, or even right
43 from VCS if it's useful to users.43 from VCS if it's useful to users.
44* should not use anything infrastructure-provider specific (i.e. querying44* should not use anything infrastructure-provider specific (i.e. querying
45 EC2 metadata service) symlinks must be self contained within a charm.45 EC2 metadata service)
46* symlinks must be self contained within a charm.
46* should make use of `AppArmor <https://juju.ubuntu.com/AppArmor>`_ to increase security47* should make use of `AppArmor <https://juju.ubuntu.com/AppArmor>`_ to increase security
4748
48Terminology49Terminology
@@ -191,3 +192,6 @@
191192
192.. [#reliable] Whether or not an external service is "reliable" is up to193.. [#reliable] Whether or not an external service is "reliable" is up to
193 the charm maintainer(s) to determine.194 the charm maintainer(s) to determine.
195
196.. [#seeded] Formally known as Ubuntu "main".
197
194198
=== modified file 'source/provider-configuration-openstack.rst'
--- source/provider-configuration-openstack.rst 2012-08-28 15:16:35 +0000
+++ source/provider-configuration-openstack.rst 2012-09-27 19:53:22 +0000
@@ -31,10 +31,6 @@
31 creating instances. As there is currently no standard image service31 creating instances. As there is currently no standard image service
32 across different OpenStack deployments, this must always be supplied.32 across different OpenStack deployments, this must always be supplied.
3333
34 default-instance-type:
35 Flavor name as given by ``nova flavor-list`` for juju to use when
36 creating instances. Setting constraints will serve the same purpose.
37
38 default-series:34 default-series:
39 Declares the Ubuntu series of the machine image. For instance, this35 Declares the Ubuntu series of the machine image. For instance, this
40 should be `precise` for an Ubuntu 12.04 image.36 should be `precise` for an Ubuntu 12.04 image.

Subscribers

People subscribed via source and target branches