Merge lp:~jorge/pyjuju/default-to-packages into lp:~charm-contributors/pyjuju/docs

Proposed by Jorge Castro
Status: Needs review
Proposed branch: lp:~jorge/pyjuju/default-to-packages
Merge into: lp:~charm-contributors/pyjuju/docs
Diff against target: 55 lines (+11/-11)
2 files modified
source/policy.rst (+11/-7)
source/provider-configuration-openstack.rst (+0/-4)
To merge this branch: bzr merge lp:~jorge/pyjuju/default-to-packages
Reviewer Review Type Date Requested Status
Clint Byrum (community) Needs Fixing
Juan L. Negron (community) Approve
Review via email: mp+126784@code.launchpad.net

Description of the change

Please don't merge yet while discussion happens on the juju list.

To post a comment you must log in.
Revision history for this message
Juan L. Negron (negronjl) wrote :

Looks good to me.

-Juan

review: Approve
Revision history for this message
Juan L. Negron (negronjl) wrote :

We should get more people's comments/reviews here before merging.

-Juan

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

I would change:

If the service is seeded

to

If the principal software needed to provide the service is available in a seeded package

Also it would be useful if you did the other 3 changes in a separate branch which this merge proposal can depend on. Its somewhat distracting seeing all of the changes at once here.

review: Needs Fixing
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

<poke> Whats the status on this?

Unmerged revisions

74. By Jorge Castro

* Revised policy to "must" default to packages if the service is in main.

73. By Jorge Castro

Fix up some footnotes

72. By Jorge Castro

* Be explicit about defaulting charms to packaged versions if in main?

71. By Jorge Castro

Remove mention of default-instance-type, this should be managed via constraints.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'source/policy.rst'
2--- source/policy.rst 2012-08-15 18:22:32 +0000
3+++ source/policy.rst 2012-09-27 19:53:22 +0000
4@@ -1,5 +1,5 @@
5-:Version: 0.1.1
6-:Authors: Clint Byrum <clint@ubuntu.com>
7+:Version: 0.1.2
8+:Authors: Clint Byrum <clint@ubuntu.com>, Jorge Castro <jorge@ubuntu.com>
9 :Date: August 15, 2012
10
11 ==================
12@@ -34,15 +34,16 @@
13 team or individual who are responsive to contact regarding the charm.
14 * must include a license. Call the file 'copyright' and make sure all
15 files' licenses are specified clearly. license_
16-* must be under a Free license. license2_
17-* must have hooks that are idempotent idempotent_
18+* must be under a Free license2_
19+* must have hooks that are idempotent_
20 * must not run any network services using default passwords.
21-* should default to use software that is included in the Ubuntu archive,
22+* If the service is seeded_ in the Ubuntu archive, it must default to that package,
23 however we encourage that charm authors have a config options for
24- allowing users to deploy from newer upstream releases, or even right
25+ allowing users to deploy from newer upstream releases, PPAs, or even right
26 from VCS if it's useful to users.
27 * should not use anything infrastructure-provider specific (i.e. querying
28- EC2 metadata service) symlinks must be self contained within a charm.
29+ EC2 metadata service)
30+* symlinks must be self contained within a charm.
31 * should make use of `AppArmor <https://juju.ubuntu.com/AppArmor>`_ to increase security
32
33 Terminology
34@@ -191,3 +192,6 @@
35
36 .. [#reliable] Whether or not an external service is "reliable" is up to
37 the charm maintainer(s) to determine.
38+
39+.. [#seeded] Formally known as Ubuntu "main".
40+
41
42=== modified file 'source/provider-configuration-openstack.rst'
43--- source/provider-configuration-openstack.rst 2012-08-28 15:16:35 +0000
44+++ source/provider-configuration-openstack.rst 2012-09-27 19:53:22 +0000
45@@ -31,10 +31,6 @@
46 creating instances. As there is currently no standard image service
47 across different OpenStack deployments, this must always be supplied.
48
49- default-instance-type:
50- Flavor name as given by ``nova flavor-list`` for juju to use when
51- creating instances. Setting constraints will serve the same purpose.
52-
53 default-series:
54 Declares the Ubuntu series of the machine image. For instance, this
55 should be `precise` for an Ubuntu 12.04 image.

Subscribers

People subscribed via source and target branches