Code review comment for lp:~jorge/pyjuju/add-icons

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Good start, but this doesn't go quite far enough. There should also be something in the charm specification that reserves /icon.svg as an icon to be displayed along with the charm. Also you should require that the icon be valid svg, and perhaps under 1MB in size or something like that.

review: Needs Fixing

« Back to merge proposal