Merge lp:~jorge/charms/precise/mysql/fix-metadata into lp:charms/mysql

Proposed by Jorge Castro
Status: Merged
Merge reported by: Tim Van Steenburgh
Merged at revision: not available
Proposed branch: lp:~jorge/charms/precise/mysql/fix-metadata
Merge into: lp:charms/mysql
Diff against target: 34 lines (+4/-2)
2 files modified
config.yaml (+2/-0)
metadata.yaml (+2/-2)
To merge this branch: bzr merge lp:~jorge/charms/precise/mysql/fix-metadata
Reviewer Review Type Date Requested Status
Tim Van Steenburgh (community) Approve
Review Queue (community) automated testing Needs Fixing
Review via email: mp+239391@code.launchpad.net

Description of the change

Fix metadata to pass proof.

To post a comment you must log in.
Revision history for this message
Review Queue (review-queue) wrote :

This items has failed automated testing! Results available here http://reports.vapour.ws/charm-tests/charm-bundle-test-1280-results

review: Needs Fixing (automated testing)
Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

Default keys were handled in a prior commit but I merged the tags change. Note that when adding default keys where none previously existed:

default:

should be used instead of

default: ""

They are not the same thing, and it is possible to inadvertently break the charm by using the second form.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2014-05-08 11:23:53 +0000
3+++ config.yaml 2014-10-23 15:19:17 +0000
4@@ -80,6 +80,7 @@
5 your ceph cluster).
6 source:
7 type: string
8+ default: ""
9 description: |
10 Optional configuration to support use of additional sources such as:
11 .
12@@ -91,6 +92,7 @@
13 option.
14 key:
15 type: string
16+ default: ""
17 description: |
18 Key ID to import to the apt keyring to support use with arbitary source
19 configuration from outside of Launchpad archives or PPA's.
20
21=== modified file 'metadata.yaml'
22--- metadata.yaml 2014-05-08 11:23:53 +0000
23+++ metadata.yaml 2014-10-23 15:19:17 +0000
24@@ -6,8 +6,8 @@
25 server. SQL (Structured Query Language) is the most popular database query
26 language in the world. The main goals of MySQL are speed, robustness and
27 ease of use.
28-categories:
29- - databases
30+tags:
31+ - database
32 provides:
33 db:
34 interface: mysql

Subscribers

People subscribed via source and target branches