Code review comment for lp:~jordanrinke/nova/lp707171

Revision history for this message
Jay Pipes (jaypipes) wrote :

Hi Jordan!

Code is fine, but warning: you'll hit a pep8 issue. You need to put 2 spaces before an inline-comment, so this:

procsetting.Limit = 100000 # static assignment to 100% since no limit/weight variable exists now.

needs to be this:

procsetting.Limit = 100000 # static assignment to 100% since no limit/weight variable exists now.

I know, silly, but it'll prevent the merge from going through :) Run ./run_tests.sh -V to run all tests and run pep8 against source files. You should see the error pop up.

Cheers!
jay

review: Needs Fixing

« Back to merge proposal