Code review comment for lp:~jontai/openvista-gtm-integration/bug552817

Revision history for this message
jeff.apple (jeff-apple) wrote :

> Thanks for the comment. I misread Mary's patch -- I thought she was calling
> some other tag with DO, but now I see she's making a recursive call. Should
> we just go back to the FOR loop approach but protect the access to RESULT with
> $G()?

I think we just move the N RESULT out of the FOR and preset it:

N RESULT S RESULT=0
F D Q:RESULT'=0
. N DR,X,Y
. ; proceed as before

Completely untested on my end, of course... just shooting from the hip.

« Back to merge proposal