Code review comment for lp:~jontai/openvista-gtm-integration/bug363080

Revision history for this message
Jon Tai (jontai) wrote :

> Looks good.
> The only corner case would be if the newline conversion converts within a
> string for a global value. I'm guessing that never happens with this data, the
> underlying tools may not support it anyway, it isn't a bad thing anyway, etc.

In ZWR format, a newline within a global is escaped with $C(...). I'm not sure what the other formats do, but if a newline shows up unescaped, it's going to confuse %RI/%GI anyway. So I don't think we're doing anything wrong here.

I'm going to commit.

« Back to merge proposal