Code review comment for lp:~jontai/openvista-gtm-integration/bug363080

Revision history for this message
jeff.apple (jeff-apple) wrote :

Looks good.
The only corner case would be if the newline conversion converts within a string for a global value. I'm guessing that never happens with this data, the underlying tools may not support it anyway, it isn't a bad thing anyway, etc.

review: Approve

« Back to merge proposal