Code review comment for lp:~jontai/openvista-gtm-integration/bug358242

Revision history for this message (jeff-apple) wrote :

In scripts/etc/init.d/openvista we have
119 elif function_exists "log_daemon_msg"; then
120 log_progress_msg "$instance"
121 run_hook "$instance" ZSTART || end_msg=1

Shouldn't line 120 be
120 log_progress_msg "Running startup hooks for $instance"

In other places, it appears the messages are different depending on whether log_daemon_msg is available or not. Not a big deal, but it might be nice to have them be the same. In fact, it might be good to make one function for the scripts that does output and do the switching there, if such a thing is possible.

Notes on building debs that seem "off":
1) Had to copy the GTM source to /tmp/ubuntu manually. It's not obvious that it has to be there.
2) Had an old gtm install in /opt/gtm that I had to ln -s /opt/gtm /tmp/gtm. I guess there's no way around that, though.
3) Had to add a group "gtm" just to build. That seems excessive.

Everything eventually did build and install.

review: Approve

« Back to merge proposal