Code review comment for lp:~joni-noplu/elisa/teletext_fix

Revision history for this message
Jonathan Rauprich (joni-noplu) wrote :

Thanks for reviewing, feel free to do so.

On Mon, 2010-05-31 at 15:47 +0000, Olivier Tilloy wrote:
> Review: Approve
> Thanks for the patch!
> I tested it and it behaves as expected.
> I have a couple of minor cosmetic remarks on the patch itself, if you don't object I'll apply the following tweaks and merge:
>
> - Typo: s/Gestreamer/GStreamer/
> - Typo: s/poping/popping/
> - I'd like the comment to include a link to the bug report (bug #415031)
> - The debug string contains extra spaces between "for" and "teletext"
>

« Back to merge proposal