Code review comment for lp:~joni-noplu/elisa/teletext_fix

Revision history for this message
Olivier Tilloy (osomon) wrote :

Thanks for the patch!
I tested it and it behaves as expected.
I have a couple of minor cosmetic remarks on the patch itself, if you don't object I'll apply the following tweaks and merge:

- Typo: s/Gestreamer/GStreamer/
- Typo: s/poping/popping/
- I'd like the comment to include a link to the bug report (bug #415031)
- The debug string contains extra spaces between "for" and "teletext"

review: Approve

« Back to merge proposal