Mixxx

Code review comment for lp:~jonathan-costers/mixxx/LP878931

  1. LP878931
  2. Merge into trunk
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Looks good to me! Thanks Jonathan and nice job on making your code blend in with wherever you were writing it. As you have surely noticed there are a variety of different styles of code lurking around the codebase :).

I have one question. Is there a standard composer field for M4A files? I noticed you haven't updated SoundSource::processMP4Tag to look for one.

Is it ok if I add you to the credits as "Jonathan Costers"?

I'm merging this to trunk now and it will be in the 1.11.0 release later this year.

review: Approve

« Back to merge proposal