Code review comment for lp:~jonas-drange/ulysses/loading-icon

Revision history for this message
Stephen Stewart (stephen-stewart) wrote :

I think the spin animation should be part of the ues-spinner class, I can't see a situation where we'd want ues-spinner without the animation?

Otherwise LGTM.

Long/medium term I think icons should be a seperate package, outside of ulysses, allowing a project to specifiy it's own icon assets (but sticking with the naming convention defined in ulysses) or use a default package. This would simply be a matter of installing/linking an icons repo of your choice via config manager along side ulysses.

« Back to merge proposal