Merge lp:~jonas-drange/ulysses/fix-watch into lp:ulysses

Proposed by Jonas G. Drange
Status: Merged
Approved by: Stephen Stewart
Approved revision: 15
Merged at revision: 16
Proposed branch: lp:~jonas-drange/ulysses/fix-watch
Merge into: lp:ulysses
Diff against target: 69 lines (+25/-6)
3 files modified
.csslintrc (+21/-4)
Gruntfile.js (+2/-2)
src/navigation.css (+2/-0)
To merge this branch: bzr merge lp:~jonas-drange/ulysses/fix-watch
Reviewer Review Type Date Requested Status
Stephen Stewart (community) Approve
Review via email: mp+200638@code.launchpad.net

Commit message

fix watch task, saner csslint

Description of the change

the watch task watched the wrong dir and executed the wrong tasks AFAICS. I've updated it to watch src/*.css, run rework and not fail during lint.

To post a comment you must log in.
lp:~jonas-drange/ulysses/fix-watch updated
15. By Jonas G. Drange

per discussion with beowulf, removing exception for duplicate properties

Revision history for this message
Stephen Stewart (stephen-stewart) :
review: Approve
lp:~jonas-drange/ulysses/fix-watch updated
16. By Jonas G. Drange

after discussion, let rework worry about vendor prefixes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.csslintrc'
--- .csslintrc 2013-12-14 07:28:45 +0000
+++ .csslintrc 2014-01-07 10:48:16 +0000
@@ -1,9 +1,26 @@
1{1{
2 "adjoining-classes": false,
3 "box-model": false,
4 "box-sizing": false,
5 "bulletproof-font-face": false,
6 "display-property-grouping": false,
7 "duplicate-background-images": false,
8 "empty-rules": false,
9 "floats": false,
10 "font-faces": false,
11 "font-sizes": false,
12 "gradients": false,
13 "import": false,
14 "non-link-hover": false,
15 "outline-none": false,
16 "overqualified-elements": false,
17 "qualified-headings": false,
2 "regex-selectors": false,18 "regex-selectors": false,
19 "shorthand": false,
20 "text-indent": false,
21 "unique-headings": false,
22 "universal-selector": false,
3 "unqualified-attributes": false,23 "unqualified-attributes": false,
4 "universal-selector": false,24 "vendor-prefix": false,
5 "box-sizing": false,
6 "unique-headings": false,
7 "qualified-headings": false,
8 "zero-units": false25 "zero-units": false
9}26}
1027
=== modified file 'Gruntfile.js'
--- Gruntfile.js 2013-12-14 07:06:03 +0000
+++ Gruntfile.js 2014-01-07 10:48:16 +0000
@@ -65,8 +65,8 @@
6565
66 watch: {66 watch: {
67 css: {67 css: {
68 files: '**/*.scss',68 files: 'src/*.css',
69 tasks: ['sass', 'concat', 'test'],69 tasks: ['rework', 'concat', 'test'],
70 options: {70 options: {
71 spawn: false71 spawn: false
72 }72 }
7373
=== modified file 'src/navigation.css'
--- src/navigation.css 2014-01-01 16:10:32 +0000
+++ src/navigation.css 2014-01-07 10:48:16 +0000
@@ -255,6 +255,7 @@
255 background-color:#f75216;255 background-color:#f75216;
256}256}
257257
258/*csslint important: false*/
258.ues-menu.user li a {259.ues-menu.user li a {
259 width:40px;260 width:40px;
260 text-indent:-9000px;261 text-indent:-9000px;
@@ -262,6 +263,7 @@
262 border:none !important;263 border:none !important;
263}264}
264265
266/*csslint important: true*/
265/** ?use a icon font for this **/267/** ?use a icon font for this **/
266.ues-menu.user li a.account {268.ues-menu.user li a.account {
267}269}

Subscribers

People subscribed via source and target branches