Merge lp:~jonas-drange/ulysses/fix-watch into lp:ulysses

Proposed by Jonas G. Drange
Status: Merged
Approved by: Stephen Stewart
Approved revision: 15
Merged at revision: 16
Proposed branch: lp:~jonas-drange/ulysses/fix-watch
Merge into: lp:ulysses
Diff against target: 69 lines (+25/-6)
3 files modified
.csslintrc (+21/-4)
Gruntfile.js (+2/-2)
src/navigation.css (+2/-0)
To merge this branch: bzr merge lp:~jonas-drange/ulysses/fix-watch
Reviewer Review Type Date Requested Status
Stephen Stewart (community) Approve
Review via email: mp+200638@code.launchpad.net

Commit message

fix watch task, saner csslint

Description of the change

the watch task watched the wrong dir and executed the wrong tasks AFAICS. I've updated it to watch src/*.css, run rework and not fail during lint.

To post a comment you must log in.
lp:~jonas-drange/ulysses/fix-watch updated
15. By Jonas G. Drange

per discussion with beowulf, removing exception for duplicate properties

Revision history for this message
Stephen Stewart (stephen-stewart) :
review: Approve
lp:~jonas-drange/ulysses/fix-watch updated
16. By Jonas G. Drange

after discussion, let rework worry about vendor prefixes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.csslintrc'
2--- .csslintrc 2013-12-14 07:28:45 +0000
3+++ .csslintrc 2014-01-07 10:48:16 +0000
4@@ -1,9 +1,26 @@
5 {
6+ "adjoining-classes": false,
7+ "box-model": false,
8+ "box-sizing": false,
9+ "bulletproof-font-face": false,
10+ "display-property-grouping": false,
11+ "duplicate-background-images": false,
12+ "empty-rules": false,
13+ "floats": false,
14+ "font-faces": false,
15+ "font-sizes": false,
16+ "gradients": false,
17+ "import": false,
18+ "non-link-hover": false,
19+ "outline-none": false,
20+ "overqualified-elements": false,
21+ "qualified-headings": false,
22 "regex-selectors": false,
23+ "shorthand": false,
24+ "text-indent": false,
25+ "unique-headings": false,
26+ "universal-selector": false,
27 "unqualified-attributes": false,
28- "universal-selector": false,
29- "box-sizing": false,
30- "unique-headings": false,
31- "qualified-headings": false,
32+ "vendor-prefix": false,
33 "zero-units": false
34 }
35
36=== modified file 'Gruntfile.js'
37--- Gruntfile.js 2013-12-14 07:06:03 +0000
38+++ Gruntfile.js 2014-01-07 10:48:16 +0000
39@@ -65,8 +65,8 @@
40
41 watch: {
42 css: {
43- files: '**/*.scss',
44- tasks: ['sass', 'concat', 'test'],
45+ files: 'src/*.css',
46+ tasks: ['rework', 'concat', 'test'],
47 options: {
48 spawn: false
49 }
50
51=== modified file 'src/navigation.css'
52--- src/navigation.css 2014-01-01 16:10:32 +0000
53+++ src/navigation.css 2014-01-07 10:48:16 +0000
54@@ -255,6 +255,7 @@
55 background-color:#f75216;
56 }
57
58+/*csslint important: false*/
59 .ues-menu.user li a {
60 width:40px;
61 text-indent:-9000px;
62@@ -262,6 +263,7 @@
63 border:none !important;
64 }
65
66+/*csslint important: true*/
67 /** ?use a icon font for this **/
68 .ues-menu.user li a.account {
69 }

Subscribers

People subscribed via source and target branches