Code review comment for lp:~jonas-drange/ubuntu-system-settings/update-reset-launcher-test

Revision history for this message
Michael Zanetti (mzanetti) wrote :

Unfortunately this doesn't catch bugs in the code... (also valid for the existing test on favorites already, probably some more)

This test still passes against current trunk, even though that code doesn't reset items. Why, you ask? Because when you run this test (either on desktop or a freshly flashed phone) the launcher's item already are set to the default. So just checking if they are still set to the default after the test doesn't cut it, you'd need to change them before the reset call.

review: Needs Fixing

« Back to merge proposal