Merge lp:~jonas-drange/ubuntu-system-settings/rtm-1378812-fix-tech-pref into lp:ubuntu-system-settings/rtm-14.09

Proposed by Jonas G. Drange
Status: Merged
Approved by: Ken VanDine
Approved revision: 945
Merged at revision: 949
Proposed branch: lp:~jonas-drange/ubuntu-system-settings/rtm-1378812-fix-tech-pref
Merge into: lp:ubuntu-system-settings/rtm-14.09
Prerequisite: lp:~ken-vandine/ubuntu-system-settings/rtm-1378812
Diff against target: 67 lines (+30/-27)
1 file modified
plugins/cellular/Components/MultiSim.qml (+30/-27)
To merge this branch: bzr merge lp:~jonas-drange/ubuntu-system-settings/rtm-1378812-fix-tech-pref
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Touch System Settings Pending
Review via email: mp+244013@code.launchpad.net

Commit message

[cellular] Use a repeater to lay out two separate ItemSelectors for modems, making sure it works well between connMan power cycles

Description of the change

[cellular] Use a repeater to lay out two separate ItemSelectors for modems, making sure it works well between connMan power cycles

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

QA has signed this off, but code-wise there is no approval so can't publish yet. Please top-approve.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/cellular/Components/MultiSim.qml'
--- plugins/cellular/Components/MultiSim.qml 2014-12-08 16:06:48 +0000
+++ plugins/cellular/Components/MultiSim.qml 2014-12-08 16:06:48 +0000
@@ -102,33 +102,36 @@
102 }[tech]102 }[tech]
103 }103 }
104104
105 ListItem.ItemSelector {105 Repeater {
106 id: radio106 model: sims
107 expanded: true107
108 text: i18n.tr("Connection type:")108 ListItem.ItemSelector {
109 model: poweredSim ? poweredSim.radioSettings.modemTechnologies : []109 id: radio
110 delegate: OptionSelectorDelegate {110 property var sim: modelData
111 objectName: poweredSim.path + "_radio_" + modelData111 property var rSettings: sim.radioSettings
112 text: techToString(modelData)112 property string techPref: rSettings.technologyPreference
113 }113 property var modemTechs: rSettings.modemTechnologies
114 enabled: poweredSim ?114 expanded: true
115 (poweredSim.radioSettings.technologyPreference !== "") : false115 text: i18n.tr("Connection type:")
116 visible: poweredSim116 model: modemTechs || []
117 selectedIndex: poweredSim ?117 delegate: OptionSelectorDelegate {
118 model.indexOf(poweredSim.radioSettings.technologyPreference) : -1118 objectName: sim.path + "_radio_" + modelData
119 onDelegateClicked: {119 text: techToString(modelData)
120 poweredSim.radioSettings.technologyPreference = model[index];120 }
121 }121 enabled: techPref !== ""
122 }122 visible: sim.connMan.powered
123123 selectedIndex: techPref !== "" ? model.indexOf(techPref) : -1
124 Connections {124 onDelegateClicked: rSettings.technologyPreference = model[index];
125 target: poweredSim ? poweredSim.radioSettings : null125 Connections {
126 onTechnologyPreferenceChanged: {126 target: rSettings
127 radio.selectedIndex =127 onTechnologyPreferenceChanged: {
128 poweredSim.radioSettings.modemTechnologies.indexOf(preference)128 radio.selectedIndex = modemTechs.indexOf(preference)
129 }129 }
130 ignoreUnknownSignals: true130 ignoreUnknownSignals: true
131 }131 }
132 }
133 }
134
132135
133 GSettings {136 GSettings {
134 id: phoneSettings137 id: phoneSettings

Subscribers

People subscribed via source and target branches