Merge lp:~jonas-drange/ubuntu-system-settings/language-kbd-layouts-weird-animation-fix-1350809 into lp:ubuntu-system-settings

[Jonas G. Drange]

[language] workaround for transition bug in keyboard layout menu

Hi,

this is a workaround. Like Sebastien said, we have to remove the transitions.

The ListView section seems to be the trigger of this bug. I've made a note to investigate this.

Thanks

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1002
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1422/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4603/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3407
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/614
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4388/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5855
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5855/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12882
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2810
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3709
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3709/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1422/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1002
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1432/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4625
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3425/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/624
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4408
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5877
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5877/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/12910
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/2828/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3728
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/3728/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1432/rebuild

review: Needs Fixing (continuous-integration)

[Sebastien Bacher (seb128)]

Things look nicer with the animation though, could we get the bug at least filed before we clean those out? otherwise it's likely that we are going to forget and let things this way

review: Needs Information

[Jonas G. Drange (jonas-drange)]

Hi, filing a bug for this is on my todo list, but presently I do not know
what to file against.

It could be the binding, but it could also be QML.

Thanks

On Tuesday, 9 September 2014, Sebastien Bacher <email address hidden> wrote:

> Review: Needs Information
>
> Things look nicer with the animation though, could we get the bug at least
> filed before we clean those out? otherwise it's likely that we are going to
> forget and let things this way
> --
>
> https://code.launchpad.net/~jonas-drange/ubuntu-system-settings/language-kbd-layouts-weird-animation-fix-1350809/+merge/233721
> You are the owner of
> lp:~jonas-drange/ubuntu-system-settings/language-kbd-layouts-weird-animation-fix-1350809.
>

[Sebastien Bacher (seb128)]

Ok, I guess no animation is better than buggy ones

review: Approve

=== modified file 'plugins/language/SubsetView.qml'
--- plugins/language/SubsetView.qml	2014-02-27 21:17:09 +0000
+++ plugins/language/SubsetView.qml	2014-09-08 13:14:31 +0000
@@ -61,35 +61,4 @@
         }
         enabled: model.enabled
     }
-
-    add: Transition {
-        NumberAnimation {
-            property: "opacity"
-            duration: duration
-            from: 0
-            to: 1
-        }
-    }
-
-    displaced: Transition {
-        NumberAnimation {
-            property: "y"
-            duration: duration
-        }
-    }
-
-    remove: Transition {
-        ParallelAnimation {
-            NumberAnimation {
-                property: "opacity"
-                duration: duration
-                to: 0
-            }
-
-            NumberAnimation {
-                property: "y"
-                duration: duration
-            }
-        }
-    }
 }