Code review comment for lp:~jonas-drange/ubuntu-system-settings/call-fwd-wait-dual-sim

Revision history for this message
Leo Arias (elopio) wrote :

590 + @property
591 + def get_forwarding(self):

Properties and attributes should be named as sustantives, and methods as verbs.
So you can either remove the @property here, or remove the "get_" part of the name. I would find it more readable with a name like get_forwarding_number.

And, please remember to use single quotes for consistency on strings. There are some places where you use " and some where you use '.

804 + call_fwd_page.set_forward("41444424")
809 + Eventually(Equals('41444424')))

pura vida.

« Back to merge proposal