Code review comment for lp:~jonas-drange/ubuntu-system-settings/about-dynamic-imei-fixes-1205294

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, is the gsettings/simnames snippet part of that changeset or some other work? It doesn't seme required for emei display...

Otherwise looks fine, might be better to only have 2 items though? The first one could have "visible: length <= 1" and "value: length = 1 ? imei : "none""

The second point is not a blocker, mostly a matter of taste so feel free to keep your version

review: Needs Information

« Back to merge proposal