Merge lp:~jonas-drange/ubuntu-settings-components/printer-state into lp:~phablet-team/ubuntu-settings-components/printer-components

Proposed by Jonas G. Drange
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 214
Merged at revision: 215
Proposed branch: lp:~jonas-drange/ubuntu-settings-components/printer-state
Merge into: lp:~phablet-team/ubuntu-settings-components/printer-components
Diff against target: 79 lines (+20/-9)
4 files modified
plugins/Ubuntu/Settings/Printers/backend/backend_cups.cpp (+10/-1)
plugins/Ubuntu/Settings/Printers/printer/printer.cpp (+1/-1)
tests/unittests/Printers/mockbackend.h (+4/-6)
tests/unittests/Printers/tst_printer.cpp (+5/-1)
To merge this branch: bzr merge lp:~jonas-drange/ubuntu-settings-components/printer-state
Reviewer Review Type Date Requested Status
Andrew Hayzen (community) Approve
Review via email: mp+315406@code.launchpad.net

Commit message

* adds read of printer state

To post a comment you must log in.
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/Ubuntu/Settings/Printers/backend/backend_cups.cpp'
--- plugins/Ubuntu/Settings/Printers/backend/backend_cups.cpp 2017-01-22 19:31:39 +0000
+++ plugins/Ubuntu/Settings/Printers/backend/backend_cups.cpp 2017-01-23 20:10:22 +0000
@@ -224,7 +224,16 @@
224224
225PrinterEnum::State PrinterCupsBackend::state() const225PrinterEnum::State PrinterCupsBackend::state() const
226{226{
227227 switch (m_info.state()) {
228 case QPrinter::Idle:
229 return PrinterEnum::State::IdleState;
230 case QPrinter::Active:
231 return PrinterEnum::State::ActiveState;
232 case QPrinter::Aborted:
233 return PrinterEnum::State::AbortedState;
234 case QPrinter::Error:
235 return PrinterEnum::State::ErrorState;
236 }
228}237}
229238
230QList<QPageSize> PrinterCupsBackend::supportedPageSizes() const239QList<QPageSize> PrinterCupsBackend::supportedPageSizes() const
231240
=== modified file 'plugins/Ubuntu/Settings/Printers/printer/printer.cpp'
--- plugins/Ubuntu/Settings/Printers/printer/printer.cpp 2017-01-22 19:31:39 +0000
+++ plugins/Ubuntu/Settings/Printers/printer/printer.cpp 2017-01-23 20:10:22 +0000
@@ -153,7 +153,7 @@
153153
154PrinterEnum::State Printer::state() const154PrinterEnum::State Printer::state() const
155{155{
156156 return m_backend->state();
157}157}
158158
159QString Printer::lastStateMessage() const159QString Printer::lastStateMessage() const
160160
=== modified file 'tests/unittests/Printers/mockbackend.h'
--- tests/unittests/Printers/mockbackend.h 2017-01-22 14:21:11 +0000
+++ tests/unittests/Printers/mockbackend.h 2017-01-23 20:10:22 +0000
@@ -335,12 +335,6 @@
335 Q_EMIT printerStateChanged(name);335 Q_EMIT printerStateChanged(name);
336 }336 }
337337
338public Q_SLOT:
339 virtual void refresh() override
340 {
341
342 }
343
344 QString returnValue = QString::null;338 QString returnValue = QString::null;
345339
346 // Map from printer to key/val.340 // Map from printer to key/val.
@@ -370,6 +364,10 @@
370 QList<Printer*> m_availablePrinters;364 QList<Printer*> m_availablePrinters;
371 PrinterBackend::BackendType m_backendType;365 PrinterBackend::BackendType m_backendType;
372366
367public Q_SLOT:
368 virtual void refresh() override
369 {
370 }
373};371};
374372
375#endif // USC_PRINTERS_MOCK_BACKEND_H373#endif // USC_PRINTERS_MOCK_BACKEND_H
376374
=== modified file 'tests/unittests/Printers/tst_printer.cpp'
--- tests/unittests/Printers/tst_printer.cpp 2017-01-22 14:21:11 +0000
+++ tests/unittests/Printers/tst_printer.cpp 2017-01-23 20:10:22 +0000
@@ -220,7 +220,11 @@
220 QCOMPARE(p.defaultPageSize(), QPageSize(QPageSize::A4));220 QCOMPARE(p.defaultPageSize(), QPageSize(QPageSize::A4));
221 QCOMPARE(p.defaultDuplexMode(), PrinterEnum::DuplexMode::DuplexNone);221 QCOMPARE(p.defaultDuplexMode(), PrinterEnum::DuplexMode::DuplexNone);
222 QCOMPARE(p.isPdf(), true);222 QCOMPARE(p.isPdf(), true);
223223 }
224 void testState()
225 {
226 getBackend()->m_state = PrinterEnum::State::AbortedState;
227 QCOMPARE(m_instance->state(), getBackend()->m_state);
224 }228 }
225private:229private:
226 QString m_printerName = "my-printer";230 QString m_printerName = "my-printer";

Subscribers

People subscribed via source and target branches