Merge lp:~jonas-drange/ubuntu-push/replace-dead-deps into lp:ubuntu-push

Proposed by Jonas G. Drange
Status: Rejected
Rejected by: Jonas G. Drange
Proposed branch: lp:~jonas-drange/ubuntu-push/replace-dead-deps
Merge into: lp:ubuntu-push
Prerequisite: lp:~osomon/ubuntu-push/update-source-format-10
Diff against target: 43 lines (+11/-6)
2 files modified
Makefile (+10/-3)
dependencies.tsv (+1/-3)
To merge this branch: bzr merge lp:~jonas-drange/ubuntu-push/replace-dead-deps
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) Disapprove
system-apps-ci-bot continuous-integration Needs Fixing
Review via email: mp+302530@code.launchpad.net

Commit message

re-enable the developer environment by replacing dead upstream dependencies with new ones, but keep the namespace intact.

Description of the change

Get the development environment working again. This is a temporary hack, the plan is to replace those dependencies, but we're blocked until lp:1606618 and lp:1606626 are solved.

Note: I've looked over the new upstream deps, but that's not much of a security audit. However, a package will never be built off of these github deps as packages are built off of golang packages in the archive.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:171
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/24/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1165/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1165
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/1048
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/1048
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/1048
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1037/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1037
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1037/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1037/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1037/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1037
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1037/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1037/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1037/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1037
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1037/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1037/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/24/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :
review: Disapprove

Unmerged revisions

171. By Jonas G. Drange

merge prereq

170. By Jonas G. Drange

nuke the changelog entry

169. By Jonas G. Drange

hack upstream deps for now

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile'
--- Makefile 2016-03-09 16:12:39 +0000
+++ Makefile 2016-08-10 10:57:08 +0000
@@ -10,8 +10,9 @@
10GODEPS = launchpad.net/gocheck10GODEPS = launchpad.net/gocheck
11GODEPS += launchpad.net/go-dbus/v111GODEPS += launchpad.net/go-dbus/v1
12GODEPS += launchpad.net/go-xdg/v012GODEPS += launchpad.net/go-xdg/v0
13GODEPS += code.google.com/p/gosqlite/sqlite313
14GODEPS += code.google.com/p/go-uuid/uuid14GODEPS += github.com/rothgar/gosqlite/sqlite3
15GODEPS += github.com/pborman/uuid
1516
16# cgocheck=0 is a workaround for lp:155519817# cgocheck=0 is a workaround for lp:1555198
17GOTEST := GODEBUG=cgocheck=0 ./scripts/goctest18GOTEST := GODEBUG=cgocheck=0 ./scripts/goctest
@@ -34,9 +35,15 @@
34 $(RM) -r $(GOPATH)/pkg35 $(RM) -r $(GOPATH)/pkg
35 mkdir -p $(GOPATH)/bin36 mkdir -p $(GOPATH)/bin
36 mkdir -p $(GOPATH)/pkg37 mkdir -p $(GOPATH)/pkg
37 go get -u launchpad.net/godeps38 go get -u github.com/rogpeppe/godeps
38 go get -d -u $(GODEPS)39 go get -d -u $(GODEPS)
39 $(GOPATH)/bin/godeps -u dependencies.tsv40 $(GOPATH)/bin/godeps -u dependencies.tsv
41
42 # Workaround for lp:1606618 and lp:1606626
43 mkdir -p $(GOPATH)/src/code.google.com/p/go-uuid/
44 ln -s $(GOPATH)/src/github.com/rothgar/gosqlite $(GOPATH)/src/code.google.com/p/gosqlite
45 ln -s $(GOPATH)/src/github.com/pborman/uuid $(GOPATH)/src/code.google.com/p/go-uuid/uuid
46
40 go install $(GODEPS)47 go install $(GODEPS)
4148
42dependencies.tsv:49dependencies.tsv:
4350
=== modified file 'dependencies.tsv'
--- dependencies.tsv 2015-11-20 15:03:47 +0000
+++ dependencies.tsv 2016-08-10 10:57:08 +0000
@@ -1,5 +1,3 @@
1code.google.com/p/go-uuid hg 7dda39b2e7d5e265014674c5af696ba4186679e9 111launchpad.net/go-dbus/v1 bzr jlenton@gmail.com-20150203130125-kqqbam1jsp3tmlk5 136
2code.google.com/p/gosqlite hg 74691fb6f83716190870cde1b658538dd4b18eb0 15
3launchpad.net/go-dbus/v1 bzr jlenton@gmail.com-20141023032446-s5icvsucwlv5o38a 129
4launchpad.net/go-xdg/v0 bzr john.lenton@canonical.com-20140208094800-gubd5md7cro3mtxa 102launchpad.net/go-xdg/v0 bzr john.lenton@canonical.com-20140208094800-gubd5md7cro3mtxa 10
5launchpad.net/gocheck bzr gustavo@niemeyer.net-20140225173054-xu9zlkf9kxhvow02 873launchpad.net/gocheck bzr gustavo@niemeyer.net-20140225173054-xu9zlkf9kxhvow02 87

Subscribers

People subscribed via source and target branches