Merge lp:~jonas-drange/ubuntu-push/remove-unused into lp:ubuntu-push

Proposed by Jonas G. Drange
Status: Merged
Approved by: Ken VanDine
Approved revision: 163
Merged at revision: 167
Proposed branch: lp:~jonas-drange/ubuntu-push/remove-unused
Merge into: lp:ubuntu-push
Diff against target: 20 lines (+1/-2)
1 file modified
server/session/session_test.go (+1/-2)
To merge this branch: bzr merge lp:~jonas-drange/ubuntu-push/remove-unused
Reviewer Review Type Date Requested Status
Ken VanDine Approve
system-apps-ci-bot continuous-integration Needs Fixing
Review via email: mp+300314@code.launchpad.net

Commit message

remove unused sess variable

Description of the change

Sems the gcgo compiler is right—sess is unused but declared. Let's drop it.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'server/session/session_test.go'
--- server/session/session_test.go 2015-12-04 15:31:27 +0000
+++ server/session/session_test.go 2016-07-18 12:49:56 +0000
@@ -166,7 +166,6 @@
166}166}
167167
168func (s *sessionSuite) TestSessionRegisterError(c *C) {168func (s *sessionSuite) TestSessionRegisterError(c *C) {
169 var sess broker.BrokerSession
170 errCh := make(chan error, 1)169 errCh := make(chan error, 1)
171 up := make(chan interface{}, 5)170 up := make(chan interface{}, 5)
172 down := make(chan interface{}, 5)171 down := make(chan interface{}, 5)
@@ -176,7 +175,7 @@
176 brkr.err = errRegister175 brkr.err = errRegister
177 go func() {176 go func() {
178 var err error177 var err error
179 sess, err = sessionStart(tp, brkr, cfg10msPingInterval5msExchangeTout, &tracker{sessionId: "s2"})178 _, err = sessionStart(tp, brkr, cfg10msPingInterval5msExchangeTout, &tracker{sessionId: "s2"})
180 errCh <- err179 errCh <- err
181 }()180 }()
182 up <- protocol.ConnectMsg{Type: "connect", ClientVer: "1", DeviceId: "dev-1"}181 up <- protocol.ConnectMsg{Type: "connect", ClientVer: "1", DeviceId: "dev-1"}

Subscribers

People subscribed via source and target branches