Code review comment for lp:~jonas-drange/ubuntu-push/control-poller

Revision history for this message
Samuele Pedroni (pedronis) wrote :

bfiller:
> wonder if there is a way to detect if we can actually send recv/data, rather than detecting a
> connection only

we have code a bit like that in

bus/connectivity

it plays a role indirectly here not in control() but step(), IsConnected() invoked there ultimately depends on the state found out through connecivity, the issue there that you need to be awake and have a bit of time to check recv/data... unless there some low level way that doesn't involve actually hitting some remote service,

as I mentioning ideally there would be one service in the system that decided "really connected/not connected", and push client would just trust it (then we could simplify code here and code in/depending on bus/connectivity)

« Back to merge proposal