Code review comment for lp:~jonas-drange/account-polld/missing-gmail-notifications

Looking into this now. Thanks for the update. :)

First of all, would you mind updating the commit message, please? Things have changed a bit since it was set. ;)

Secondly, I think that the approach looks good but that there are probably still some issues with the implementation. The first thing which comes to my mind here is time zone stuff. What if we are in a different timezone than the Gmail server and our date is already one day ahead of the Gmail server? This can potentially result in a lot of missed emails, depending on your location!

For that reason, I believe that the old solution using newer_than:1d worked a lot better.

Besides using another selector here and potentially missing emails, I don't see any advancements compared to the older version. We have no way to check for messages which arrived exactly after our last poll, as the server does not accept hours/minutes/seconds in the query.

For that reason, I suggest reverting the last commit and going with the previous version. If I understood him correctly, the only complaints Bill made were the incorrect sorting and not being able to check for mails which arrived *exactly* after the last check, which we have found not to be possible. He seemed to be okay with how it worked.

Let me know what you think. :)