Code review comment for lp:~jon-hill/fluidity/diagnostic_check
Revision history for this message
| Jon Hill (jon-hill) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
1) The ALL CAPS are my code styling. I'll change the .OR. to .or., but the DEP_LOOP stays (I find it easier to spot in amongst the lower case code)
2) Not sure I entirely follow - if you have multiple phase support in your diagnostic, then it will appear in case(2) and you may still want to use, say, DistanceToBottom, which is one of the extra fields that can be checked for. The relative_path fields are checked within the correct material phase, but the others are absolute paths. Unless I got all this wrong! :)
3) Forgot to add the new module that contains the variables...fixed.