Code review comment for lp:~jon-hill/fluidity/diagnostic_check

A few points:
* you have a few ALL CAPS words in there that shouldn't be: .OR. and DEP_LOOP
* in case(2) split_dependency(1) is the phase_name and split_dependency(2) is the field name, so the checks for additional fields after that as they currently are, don't make any sense.
* where is additional_diagnostic_fields defined? I can't find it anywhere...