Code review comment for lp:~joke/bzr/bugfix353370
Revision history for this message
| Joke de Buhr (joke) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
> I agree with John about being careful when accessing sys.stdout
> (even if StringIO objects provides a isatty()).
>
> I'd also really like to have a comment there explaining the magic value
> (why 10.000 and not 65536 or 1024 ?) and the intent (a value big enough
> to never truncate lines ?).
>
> I'll tweak and merge.
10000 is a number which:
- would probably be big enough to never truncate lines.
- representable as an 16bit unsigned integer ( 2^(16-1) ).