Code review comment for lp:~johnweldon4/juju-core/action

Revision history for this message
John Weldon (johnweldon4) wrote :

https://codereview.appspot.com/98260043/diff/1/state/state.go
File state/state.go (right):

https://codereview.appspot.com/98260043/diff/1/state/state.go#newcode1379
state/state.go:1379: func (st *State) AddAction(unit string, name
string, payload interface{}) (*Action, error) {
On 2014/05/15 12:47:27, fwereade wrote:
> Thinking about this: I think it should be (u *Unit) AddAction(name
string,
> payload interface{}) (...).

> Should be a simple move (and also make it easier to assert that the
unit isn't
> dead).

I'm assuming we put the Action doc in the same actions collection on
state? We're just doing the add on the Unit?

https://codereview.appspot.com/98260043/

« Back to merge proposal