Merge lp:~johnsca/charms/trusty/neutron-calico/review into lp:~project-calico/charms/trusty/neutron-calico/trunk

Proposed by Cory Johns
Status: Merged
Merged at revision: 64
Proposed branch: lp:~johnsca/charms/trusty/neutron-calico/review
Merge into: lp:~project-calico/charms/trusty/neutron-calico/trunk
Diff against target: 46 lines (+4/-4)
3 files modified
Makefile (+1/-1)
README.md (+2/-2)
metadata.yaml (+1/-1)
To merge this branch: bzr merge lp:~johnsca/charms/trusty/neutron-calico/review
Reviewer Review Type Date Requested Status
Matt Dupre Approve
Review via email: mp+276889@code.launchpad.net

Description of the change

Fixed README and testdep target

To post a comment you must log in.
65. By Cory Johns

Fixed charm proof warning

Revision history for this message
Matt Dupre (matthew-dupre) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'Makefile'
--- Makefile 2015-03-12 16:11:07 +0000
+++ Makefile 2015-11-06 16:28:49 +0000
@@ -7,7 +7,7 @@
7 @charm proof7 @charm proof
88
9testdep:9testdep:
10 @sudo apt-get install -q -y python-nose python-mock python-netaddr python-netifaces10 @sudo apt-get install -q -y python-nose python-mock python-netaddr python-netifaces python-jinja2
1111
12test: testdep12test: testdep
13 @echo Starting tests...13 @echo Starting tests...
1414
=== modified file 'README.md'
--- README.md 2015-08-28 08:03:17 +0000
+++ README.md 2015-11-06 16:28:49 +0000
@@ -11,14 +11,14 @@
11To deploy (partial deployment of linked charms only):11To deploy (partial deployment of linked charms only):
1212
13 juju deploy rabbitmq-server13 juju deploy rabbitmq-server
14 juju deploy cs:~project-calico/neutron-api14 juju deploy neutron-api
15 juju deploy nova-compute15 juju deploy nova-compute
16 juju deploy cs:~kubernetes/etcd16 juju deploy cs:~kubernetes/etcd
17 juju deploy cs:~project-calico/neutron-calico17 juju deploy cs:~project-calico/neutron-calico
18 juju add-relation neutron-calico nova-compute18 juju add-relation neutron-calico nova-compute
19 juju add-relation neutron-calico neutron-api19 juju add-relation neutron-calico neutron-api
20 juju add-relation neutron-calico rabbitmq-server20 juju add-relation neutron-calico rabbitmq-server
21 juju add-relation neutron-calico etcd:etcd-peer21 juju add-relation neutron-calico etcd
2222
23When deploying at scale, you should optionally add a BGP route reflector:23When deploying at scale, you should optionally add a BGP route reflector:
2424
2525
=== modified file 'metadata.yaml'
--- metadata.yaml 2015-06-19 08:17:39 +0000
+++ metadata.yaml 2015-11-06 16:28:49 +0000
@@ -14,7 +14,7 @@
14 .14 .
15 This charm provides the OpenStack Neutron Calico Agent, managing15 This charm provides the OpenStack Neutron Calico Agent, managing
16 L3 connectivity on nova-compute services.16 L3 connectivity on nova-compute services.
17categories:17tags:
18 - openstack18 - openstack
19provides:19provides:
20 neutron-plugin:20 neutron-plugin:

Subscribers

People subscribed via source and target branches