Merge lp:~johnsca/charms/trusty/nagios/all-tests into lp:~nicopace/charms/trusty/nagios/all-tests

Proposed by Cory Johns
Status: Merged
Merge reported by: nicopace
Merged at revision: not available
Proposed branch: lp:~johnsca/charms/trusty/nagios/all-tests
Merge into: lp:~nicopace/charms/trusty/nagios/all-tests
Diff against target: 31 lines (+3/-0)
2 files modified
tests/21-monitors-interface-test (+2/-0)
tests/22-extraconfig-test (+1/-0)
To merge this branch: bzr merge lp:~johnsca/charms/trusty/nagios/all-tests
Reviewer Review Type Date Requested Status
nicopace Approve
Review via email: mp+252786@code.launchpad.net

Description of the change

Fixes from review.

To post a comment you must log in.
Revision history for this message
nicopace (nicopace) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/21-monitors-interface-test'
--- tests/21-monitors-interface-test 2015-02-04 15:27:29 +0000
+++ tests/21-monitors-interface-test 2015-03-12 17:20:33 +0000
@@ -10,6 +10,7 @@
10d.add('nagios')10d.add('nagios')
11d.add('mysql')11d.add('mysql')
12d.add('nrpe')12d.add('nrpe')
13d.add('mediawiki')
1314
14d.relate('mysql:db', 'mediawiki:db')15d.relate('mysql:db', 'mediawiki:db')
15d.relate('nagios:monitors', 'mysql:monitors')16d.relate('nagios:monitors', 'mysql:monitors')
@@ -21,6 +22,7 @@
2122
22try:23try:
23 d.setup(timeout=seconds)24 d.setup(timeout=seconds)
25 d.sentry.wait()
24except amulet.helpers.TimeoutError:26except amulet.helpers.TimeoutError:
25 amulet.raise_status(amulet.SKIP, msg="Environment wasn't stood up in time")27 amulet.raise_status(amulet.SKIP, msg="Environment wasn't stood up in time")
26except:28except:
2729
=== modified file 'tests/22-extraconfig-test'
--- tests/22-extraconfig-test 2015-02-04 17:59:21 +0000
+++ tests/22-extraconfig-test 2015-03-12 17:20:33 +0000
@@ -15,6 +15,7 @@
1515
16try:16try:
17 d.setup(timeout=seconds)17 d.setup(timeout=seconds)
18 d.sentry.wait()
18except amulet.helpers.TimeoutError:19except amulet.helpers.TimeoutError:
19 amulet.raise_status(amulet.SKIP, msg="Environment wasn't stood up in time")20 amulet.raise_status(amulet.SKIP, msg="Environment wasn't stood up in time")
20except:21except:

Subscribers

People subscribed via source and target branches

to all changes: