Thanks for this, since it depends on the helpers change lets resolve that before I can approve this. Good stuff though.
https://codereview.appspot.com/104820043/diff/20001/metadata.yaml File metadata.yaml (right):
https://codereview.appspot.com/104820043/diff/20001/metadata.yaml#newcode3 metadata.yaml:3: maintainer: cf-charmers ha, nice catch. we might want to use the full email address for cf-charmers though, or say lp:~cf-charmers. Something to make it a little more clear.
https://codereview.appspot.com/104820043/diff/20001/templates/hm9000.json File templates/hm9000.json (right):
https://codereview.appspot.com/104820043/diff/20001/templates/hm9000.json#newcode14 templates/hm9000.json:14: {% for unit in etcd.values() -%} This might change a little if you like the helpers changes suggested in the other branch. Thanks for this important fix.
https://codereview.appspot.com/104820043/
« Back to merge proposal
Thanks for this, since it depends on the helpers change lets resolve
that before I can approve this. Good stuff though.
https:/ /codereview. appspot. com/104820043/ diff/20001/ metadata. yaml
File metadata.yaml (right):
https:/ /codereview. appspot. com/104820043/ diff/20001/ metadata. yaml#newcode3
metadata.yaml:3: maintainer: cf-charmers
ha, nice catch. we might want to use the full email address for
cf-charmers though, or say lp:~cf-charmers. Something to make it a
little more clear.
https:/ /codereview. appspot. com/104820043/ diff/20001/ templates/ hm9000. json hm9000. json (right):
File templates/
https:/ /codereview. appspot. com/104820043/ diff/20001/ templates/ hm9000. json#newcode14 hm9000. json:14: {% for unit in etcd.values() -%}
templates/
This might change a little if you like the helpers changes suggested in
the other branch. Thanks for this important fix.
https:/ /codereview. appspot. com/104820043/