Code review comment for lp:~johnsca/charms/trusty/cf-hm9000/services

Reviewers: mp+221770_code.launchpad.net,

Message:
Please take a look.

Description:
Finished charm using services framework

https://code.launchpad.net/~johnsca/charms/trusty/cf-hm9000/services/+merge/221770

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/104820043/

Affected files (+1064, -879 lines):
   A [revision details]
   D files/README.md
   D files/default-config.json
   A files/hm9000
   D files/hm9000.json.erb
   D files/hm9000_analyzer_ctl
   D files/hm9000_api_server_ctl
   D files/hm9000_evacuator_ctl
   D files/hm9000_fetcher_ctl
   D files/hm9000_listener_ctl
   D files/hm9000_metrics_server_ctl
   D files/hm9000_sender_ctl
   D files/hm9000_shredder_ctl
   D files/syslog_forwarder.conf.erb
   A hooks/cc-relation-changed
   M hooks/charmhelpers/contrib/cloudfoundry/common.py
   D hooks/charmhelpers/contrib/cloudfoundry/config_helper.py
   M hooks/charmhelpers/contrib/cloudfoundry/contexts.py
   D hooks/charmhelpers/contrib/cloudfoundry/install.py
   D hooks/charmhelpers/contrib/cloudfoundry/services.py
   D hooks/charmhelpers/contrib/cloudfoundry/upstart_helper.py
   M hooks/charmhelpers/contrib/openstack/context.py
   M hooks/charmhelpers/contrib/openstack/neutron.py
   M hooks/charmhelpers/contrib/openstack/utils.py
   M hooks/charmhelpers/contrib/storage/linux/lvm.py
   M hooks/charmhelpers/contrib/storage/linux/utils.py
   M hooks/charmhelpers/core/hookenv.py
   M hooks/charmhelpers/core/host.py
   A hooks/charmhelpers/core/services.py
   A hooks/charmhelpers/core/templating.py
   M hooks/charmhelpers/fetch/__init__.py
   A hooks/config.py
   M hooks/config-changed
   A hooks/etcd-relation-changed
   M hooks/install
   A hooks/metrics-relation-changed
   A hooks/nats-relation-changed
   D hooks/relation-name-relation-broken
   D hooks/relation-name-relation-changed
   D hooks/relation-name-relation-departed
   D hooks/relation-name-relation-joined
   M hooks/start
   M hooks/stop
   M hooks/upgrade-charm
   M metadata.yaml
   D notes.md
   A templates/cf-hm9k-analyzer.conf
   A templates/cf-hm9k-api-server.conf
   A templates/cf-hm9k-evacuator.conf
   A templates/cf-hm9k-fetcher.conf
   A templates/cf-hm9k-listener.conf
   A templates/cf-hm9k-metrics-server.conf
   A templates/cf-hm9k-sender.conf
   A templates/cf-hm9k-shredder.conf
   A templates/hm9000.json