Juju Charms Collection
cf-go-router package

Code review comment for lp:~johnsca/charms/trusty/cf-go-router/services-callback-fu

  1. Trusty Tahr (14.04)
  2. services-callback-fu
  3. Merge into trunk
Revision history for this message
Cory Johns (johnsca) wrote :

On 2014/05/29 18:51:20, benjamin.saller wrote:
> hooks/config.py:23: result = subprocess.check_output(['dig', '+short',
> mailto:, address])
> thank you google, there should be a better way, but I've done this too

> hooks/config.py:38: 'ports': [80, 443],
> we still expose 443 but its aspirational iirc

Yeah, I just moved the existing logic, but it did seem like a strange
approach to me. I expected juju to provide a way to fetch the IP
address instead of the resolved name.

https://codereview.appspot.com/104720044/

« Back to merge proposal