Juju Charms Collection
cf-go-router package

Code review comment for lp:~johnsca/charms/trusty/cf-go-router/services-callback-fu

  1. Trusty Tahr (14.04)
  2. services-callback-fu
  3. Merge into trunk
Revision history for this message
Benjamin Saller (bcsaller) wrote :

LGTM, thanks

https://codereview.appspot.com/104720044/diff/1/hooks/config.py
File hooks/config.py (right):

https://codereview.appspot.com/104720044/diff/1/hooks/config.py#newcode23
hooks/config.py:23: result = subprocess.check_output(['dig', '+short',
'@8.8.8.8', address])
thank you google, there should be a better way, but I've done this too

https://codereview.appspot.com/104720044/diff/1/hooks/config.py#newcode38
hooks/config.py:38: 'ports': [80, 443],
we still expose 443 but its aspirational iirc

https://codereview.appspot.com/104720044/

« Back to merge proposal