I think that it would be better to rename gorouter.conf upstart job to
cf-gorouter.conf or cf-go-router.conf (I mean this change https://codereview.appspot.com/96360049/patch/20001/30021),
just to do it in the same way with other charms.
On 21 May 2014 01:03, Cory Johns <email address hidden> wrote:
I think that it would be better to rename gorouter.conf upstart job to /codereview. appspot. com/96360049/ patch/20001/ 30021),
cf-gorouter.conf or cf-go-router.conf (I mean this change
https:/
just to do it in the same way with other charms.
On 21 May 2014 01:03, Cory Johns <email address hidden> wrote:
> *** Submitted: /codereview. appspot. com/96360049 /codereview. appspot. com/96360049/ /code.launchpad .net/~johnsca/ charms/ trusty/ cf-go-router/ refactor/ +merge/ 219914 /launchpad. net/~cf- charmers /launchpad. net/~cf- charmers /help.launchpad .net/ListHelp
>
> Refactored to use refactored charm-helpers
>
> R=benjamin.saller
> CC=
> https:/
>
>
> https:/
>
> --
>
> https:/
> Your team Cloud Foundry Charmers is requested to review the proposed merge
> of lp:~johnsca/charms/trusty/cf-go-router/refactor into
> lp:~cf-charmers/charms/trusty/cf-go-router/trunk.
>
> --
> Mailing list: https:/
> Post to : <email address hidden>
> Unsubscribe : https:/
> More help : https:/
>