Juju Charms Collection
cf-go-router package

Code review comment for lp:~johnsca/charms/trusty/cf-go-router/port-conflicts

  1. Trusty Tahr (14.04)
  2. port-conflicts
  3. Merge into trunk
Revision history for this message
Benjamin Saller (bcsaller) wrote :

LGTM

Nice fix for the port handling

https://codereview.appspot.com/103270043/diff/40001/hooks/charmhelpers/core/services.py
File hooks/charmhelpers/core/services.py (right):

https://codereview.appspot.com/103270043/diff/40001/hooks/charmhelpers/core/services.py#newcode348
hooks/charmhelpers/core/services.py:348: for port in new_ports:
Cool, thanks

https://codereview.appspot.com/103270043/diff/40001/hooks/config.py
File hooks/config.py (right):

https://codereview.appspot.com/103270043/diff/40001/hooks/config.py#newcode39
hooks/config.py:39: 'ports': [hookenv.config('port')],
funny that we use the hookenv.config()['domain'] above and this here. I
didn't recall that it even did per-key lookup :)

https://codereview.appspot.com/103270043/

« Back to merge proposal