Merge lp:~johnsca/charms/trusty/apache-hadoop-yarn-master/etc-hosts-refactor into lp:~bigdata-dev/charms/trusty/apache-hadoop-yarn-master/trunk

Proposed by Cory Johns
Status: Merged
Merged at revision: 86
Proposed branch: lp:~johnsca/charms/trusty/apache-hadoop-yarn-master/etc-hosts-refactor
Merge into: lp:~bigdata-dev/charms/trusty/apache-hadoop-yarn-master/trunk
Diff against target: 44 lines (+9/-3) (has conflicts)
2 files modified
hooks/common.py (+5/-3)
resources.yaml (+4/-0)
Text conflict in resources.yaml
To merge this branch: bzr merge lp:~johnsca/charms/trusty/apache-hadoop-yarn-master/etc-hosts-refactor
Reviewer Review Type Date Requested Status
Kevin W Monroe Approve
Review via email: mp+262463@code.launchpad.net

Description of the change

Use refactored /etc/hosts handling

To post a comment you must log in.
Revision history for this message
Kevin W Monroe (kwmonroe) wrote :

lgtm, especially the bzr artifacts. merged.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/common.py'
--- hooks/common.py 2015-05-13 16:48:39 +0000
+++ hooks/common.py 2015-06-19 15:38:13 +0000
@@ -51,6 +51,7 @@
51 hs_port = dist_config.port('jh_webapp_http')51 hs_port = dist_config.port('jh_webapp_http')
52 nodemanagers = jujubigdata.relations.ResourceManagerMaster(spec=hadoop.spec, port=port, historyserver_port=hs_port)52 nodemanagers = jujubigdata.relations.ResourceManagerMaster(spec=hadoop.spec, port=port, historyserver_port=hs_port)
53 clients = jujubigdata.relations.ResourceManager(spec=hadoop.spec, port=port, historyserver_port=hs_port)53 clients = jujubigdata.relations.ResourceManager(spec=hadoop.spec, port=port, historyserver_port=hs_port)
54 namenode = jujubigdata.relations.NameNode(spec=hadoop.client_spec)
54 manager = charmframework.Manager([55 manager = charmframework.Manager([
55 {56 {
56 'name': 'hadoop-base',57 'name': 'hadoop-base',
@@ -69,12 +70,13 @@
69 ],70 ],
70 'requires': [71 'requires': [
71 hadoop.is_installed,72 hadoop.is_installed,
72 jujubigdata.relations.NameNode(spec=hadoop.client_spec),73 namenode,
73 jujubigdata.relations.NodeManager(optional=True),74 jujubigdata.relations.NodeManager(optional=True),
74 ],75 ],
75 'callbacks': [76 'callbacks': [
76 nodemanagers.register_host_ips,77 nodemanagers.register_connected_hosts,
77 jujubigdata.utils.update_etc_hosts_from_kv,78 namenode.register_provided_hosts,
79 jujubigdata.utils.manage_etc_hosts,
78 hdfs.configure_client,80 hdfs.configure_client,
79 yarn.configure_resourcemanager,81 yarn.configure_resourcemanager,
80 yarn.configure_jobhistory,82 yarn.configure_jobhistory,
8183
=== modified file 'resources.yaml'
--- resources.yaml 2015-06-10 21:51:54 +0000
+++ resources.yaml 2015-06-19 15:38:13 +0000
@@ -8,7 +8,11 @@
8 six:8 six:
9 pypi: six9 pypi: six
10 jujubigdata:10 jujubigdata:
11<<<<<<< TREE
11 pypi: jujubigdata>=1.2.14,<2.0.012 pypi: jujubigdata>=1.2.14,<2.0.0
13=======
14 pypi: jujubigdata>=2.0.0,<3.0.0
15>>>>>>> MERGE-SOURCE
12 charmhelpers:16 charmhelpers:
13 pypi: http://bazaar.launchpad.net/~bigdata-dev/bigdata-data/trunk/download/kevin.monroe%40canonical.com-20150610215108-gq4ud2rriy1sp1h6/charmhelpers0.3.1.ta-20150610215050-vxrqhizdsrqwnmcm-1/charmhelpers-0.3.1.tar.gz17 pypi: http://bazaar.launchpad.net/~bigdata-dev/bigdata-data/trunk/download/kevin.monroe%40canonical.com-20150610215108-gq4ud2rriy1sp1h6/charmhelpers0.3.1.ta-20150610215050-vxrqhizdsrqwnmcm-1/charmhelpers-0.3.1.tar.gz
14 hash: 061fe7204289b96fab5d3ca02883040ea3026526ebf0ad38e21457527a18d13918 hash: 061fe7204289b96fab5d3ca02883040ea3026526ebf0ad38e21457527a18d139

Subscribers

People subscribed via source and target branches