Code review comment for lp:~johnsca/charm-helpers/services-framework

Revision history for this message
Charles Butler (lazypower) wrote :

Looks good to me. I'm on teh band wagon for using this as well.

I see nothing truly heinous in the code base, and considering there are already a slew of CF charms relying on this - I'd like to get more traction. Merging so we can pilot this officially in charms and get a charm-school published on this.

Make sure you're watching the charm-helpers bug tracker for any incoming bugs related to the services framework, and thank you for helping solve some long running issues with a very unique approach to service declaration, implementation, and constraints (on a per service level via relation even!)

+1

review: Approve

« Back to merge proposal