Code review comment for lp:~johnsca/charm-helpers/services-framework

Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :

+1 LGTM.

This is awesome, I can't wait to try it out! I found a few typos (see inline diff comments), but other than that, this is good-to-go. Tests all pass.

Looking forward to implementing a charm with this to get a better feel for it. You might consider adding more examples to the published docs (http://pythonhosted.org/charmhelpers/) if you get time.

Very nice work!

review: Approve

« Back to merge proposal