Code review comment for lp:~johnsca/charm-helpers/services-callback-fu

Revision history for this message
Cory Johns (johnsca) wrote :

Reviewers: mp+220733_code.launchpad.net,

Message:
Please take a look.

Description:
Callbacks instead of ServiceManagers

Refactored charmhelpers.core.services to use callbacks instead of
service types / managers, to make it easier for charms to specify
custom behavior.

https://code.launchpad.net/~johnsca/charm-helpers/services-callback-fu/+merge/220733

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/98490043/

Affected files (+146, -92 lines):
   A [revision details]
   M charmhelpers/core/host.py
   M charmhelpers/core/services.py
   M charmhelpers/core/templating.py
   M tests/core/test_host.py
   M tests/core/test_services.py
   M tox.ini

« Back to merge proposal