Code review comment for lp:~johnsca/charm-helpers/multi-unit
Revision history for this message
| Benjamin Saller (bcsaller) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Thanks for this, very close. Mostly this comes down to me wanting
another pass over the examples/docs around the multi-unit data access.
Hopefully I pointed to what I am after clearly, if not please let me
know.
https:/
File charmhelpers/
https:/
charmhelpers/
['address', 'port', 'user', 'password']
You have a follow on for the charms updating the templates as well?
https:/
charmhelpers/
['hostname', 'port']
I am a little cautious about this one as this isn't really a CF
component, it would be interesting if down the road we had something
like
EtcdInterface = charmhelpers.
To produce this class from a interface registry. We'll want that sort of
thing for the interface testing plans anyway.
just rambling, nothing to do now.
https:/
File charmhelpers/
https:/
charmhelpers/
This feels a bit magical. I'm fine with letting it in but the 'why'
you'd use it both ways should be explained a little more below. See my
following comment about the example being a bit unclear.
https:/
charmhelpers/
I worry that this example isn't clear. self.interface and the 'foo' key
are assumed.
I'd like two examples here in the style of
'if you need to iterate all the units of a relation, for example in a
template, you can ...'
'if you want the keys and values of any matching unit containing all the
expected keys of an interface, you can ...'
sorry to ask you to rephrase this, and thank you.
https:/