Code review comment for lp:~johnsca/charm-helpers/adduser-group
Revision history for this message
| Stuart Bishop (stub) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Can we have better parameter names than 'group' and 'groups'? eg. primary_group and secondary_groups? The current naming will certainly cause confusion, particularly when the docstring contains no hints for the new parameters.
Some tests would be nice but this is a simple enough update.