Code review comment for lp:~john-j-beard/kicad/moveexact

Revision history for this message
Maciej Suminski (orsonmmz) wrote :

Hi John,

I am sorry that you had to wait so long for the feedback. There are some
conflicts in the branch, but it seems to me that bzr is simply overwhelmed with
merging process, and a bunch of interleaved "bzr rebase-continue" and "bzr
resolve --take-other" seems to fix the problem.

There are some minor issues with the legacy renderer in layout editor - you can
invoke duplicate/create array/move exact for individual pads. Move exact for
pads might be intentional, and it works, but duplicate just fires an assert.
Nothing major, KiCad does not explode, but it would be good to address the
problem.

In GAL, the ratsnest is not updated once an array was created. One day (I feel
like I am promising this since ever), we will have an observer to follow the changes.
Then such explicit updates will not be necessary, but at the moment it is required.
Again, nothing serious.

Overall, it is a great add-on for KiCad. I am really impressed with the
provided features, and I think it would be a pity not to have in the master
repository. Once the minor things are fixed, and Wayne gives the green light I
can handle the merging process. Thank you!

Regards,
Orson

review: Needs Fixing

« Back to merge proposal