OpenLP

Code review comment for lp:~john+ubuntu-g/openlp/singingthefaith

  1. singingthefaith
  2. Merge into trunk
Revision history for this message
Phill (phill-ridout) wrote :

Please change your string formatting to use the 'new' style with the format function. ( https://pyformat.info/ ) also string formatting is preferred over concatenation (i.e, "part1" + var + "part2")

single quotes for strings, not double quotes

do_import_file is very long can this be split in to smaller methods?

review: Needs Fixing

« Back to merge proposal