Code review comment for lp:~johannes.erdfelt/nova/lp844905

Revision history for this message
Paul Voccio (pvo) wrote :

Wanted to echo removing comments and some of the formatting the others mentioned here.

I got some 3 failures with the S3APITestCase. Not sure if this is related or not yet.

Please also add yourself to the Authors file. This failed on the unit tests for me.

======================================================================
FAIL: test_authors_up_to_date (nova.tests.test_misc.ProjectTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/bzr/TrustedComputingPools/nova/tests/test_misc.py", line 93, in test_authors_up_to_date
    '%r not listed in Authors' % missing)
AssertionError: set([u'<email address hidden>']) not listed in Authors

review: Needs Fixing

« Back to merge proposal