Code review comment for lp:~joetalbott/utah/doc_client_updates
Revision history for this message
| Max Brustkern (nuclearbob) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
On line 31 of the merge:
'Name' must correspond tot the
I'm guessing you mean "to the".
On line 42:
has cachedd credentials
Maybe "cached"?
Finally, when tc_setup sets up the "environment" this doesn't appear to include any propagating environment variables defined in tc_setup into the environment used to run the actual command. I'm guessing this is intentional, but it might be useful to note that in here somewhere? I'm not sure of the best way to put it.
Other than that, good stuff.