Code review comment for lp:~joetalbott/utah/add_dev_method

Revision history for this message
Javier Collado (javier.collado) wrote :

In any case, I'd like to comment that it looks a little bit weird that:

- test cases use VCSHandler.get_revision and code in runner module uses VCSHandler.revision
(even if the former wraps the latter).

- to implement a fake version command a call to a real command (echo DEVELOPMENT) is needed.

« Back to merge proposal