Merge lp:~joetalbott/uci-engine/cli_config_option into lp:uci-engine

Proposed by Joe Talbott
Status: Merged
Approved by: Chris Johnston
Approved revision: 453
Merged at revision: 463
Proposed branch: lp:~joetalbott/uci-engine/cli_config_option
Merge into: lp:uci-engine
Diff against target: 21 lines (+3/-1)
1 file modified
cli/ubuntu-ci (+3/-1)
To merge this branch: bzr merge lp:~joetalbott/uci-engine/cli_config_option
Reviewer Review Type Date Requested Status
Chris Johnston (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Evan (community) Approve
Review via email: mp+217933@code.launchpad.net

Commit message

cli - Add -c config option.

Description of the change

cli - Add -c config option.

To post a comment you must log in.
Revision history for this message
Evan (ev) wrote :

Sorry for even wasting the time discussing this! I had no idea it'd be so small. :)

review: Approve
Revision history for this message
Chris Johnston (cjohnston) wrote :

That's just cause he didn't write any tests :-)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:452
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/570/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/570/rebuild

review: Needs Fixing (continuous-integration)
453. By Joe Talbott

cli - make -c a global flag.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:453
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/576/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/576/rebuild

review: Approve (continuous-integration)
Revision history for this message
Chris Johnston (cjohnston) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'cli/ubuntu-ci'
--- cli/ubuntu-ci 2014-03-17 17:17:25 +0000
+++ cli/ubuntu-ci 2014-05-02 17:37:38 +0000
@@ -37,6 +37,7 @@
37 default=1, type=int, choices=[1, 2, 3],37 default=1, type=int, choices=[1, 2, 3],
38 help='Verbosity level; 1=errors only, 2=verbose '38 help='Verbosity level; 1=errors only, 2=verbose '
39 'output, 3=very verbose output')39 'output, 3=very verbose output')
40 parser.add_argument('-c', '--config', help='Config file')
40 subparsers = parser.add_subparsers(title='actions', help='commands')41 subparsers = parser.add_subparsers(title='actions', help='commands')
41 ticket_parser = subparsers.add_parser('create_ticket',42 ticket_parser = subparsers.add_parser('create_ticket',
42 help='Create a new ticket')43 help='Create a new ticket')
@@ -121,7 +122,8 @@
121 # We're not in create_ticket context, moving on.122 # We're not in create_ticket context, moving on.
122 pass123 pass
123124
124 utils.load_config(utils.DEF_CFG)125 config_file = args.config if args.config else utils.DEF_CFG
126 utils.load_config(config_file)
125 args.func(args)127 args.func(args)
126 return 0128 return 0
127 except utils.InputError as exc:129 except utils.InputError as exc:

Subscribers

People subscribed via source and target branches